⚠️ No Changeset found

Latest commit: d25a499

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6882249059/npm-package-wrangler-3026

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6882249059/npm-package-wrangler-3026

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6882249059/npm-package-wrangler-3026 dev path/to/script.js

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6882249059/npm-package-miniflare-3026

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6882249059/npm-package-cloudflare-pages-shared-3026

wrangler@3.15.0 includes the following runtime dependencies:

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Codecov Report

Merging #3026 (d25a499) into main (3753eaf) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   75.46%   75.50%   +0.03%     
==========================================
  Files         225      225              
  Lines       12478    12478              
  Branches     3239     3239              
==========================================
+ Hits         9417     9421       +4     
+ Misses       3061     3057       -4     

Please run Prettier
npm run fix

Checks are failing because a test timed out: → Test timed out in 30000ms.
I don't think it's related to my changes.

I suggest we use example from the workers-rs repo, it's compact and does the job.

use worker::*;

#[event(fetch)]
pub async fn main(req: Request, env: Env, _ctx: worker::Context) -> Result<Response> {
    console_log!(
        "{} {}, located at: {:?}, within: {}",
        req.method().to_string(),
        req.path(),
        req.cf().coordinates().unwrap_or_default(),
        req.cf().region().unwrap_or("unknown region".into())
    );

    if !matches!(req.method(), Method::Post) {
        return Response::error("Method Not Allowed", 405);
    }

    if let Some(file) = req.form_data().await?.get("file") {
        return match file {
            FormEntry::File(buf) => {
                Response::ok(&format!("size = {}", buf.bytes().await?.len()))
            }
            _ => Response::error("`file` part of POST form must be a file", 400),
        };
    }

    Response::error("Bad Request", 400)
}

@JacobMGEvans are you happy with these changes? If so, would you be able to approve and merge?

@Alex1607 Could this link to workers-rs README? Since this is just a copy of that I feel like that would make sense in the case the reader wants to read more or any changes are made to this example based on changes in workers-rs. Honestly I feel like it would make the most sense to remove the snippet entirely and just say you could go to this link for more info but if you feel like it makes sense to include it that's fine with me

hi @Alex1607 :) could you please note that the snippet comes from workers-rs and include a link, and comment that for up to date info users should follow the link? thanks!

@jspspike @lrapoport-cf sorry for the delay, I just adjusted the readme

How is the merging done? Do I still have to do something, or will someone take over from now?

thanks @Alex1607 , we've merged the change 👍